Login  Register

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4102: [CARBONDATA-4144] During compaction, the segment lock of SI table is not released in abnormal scenarios.

Posted by GitBox on Mar 17, 2021; 9:55am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-liuhe0702-opened-a-new-pull-request-4102-CARBONDATA-4144-After-the-alter-table-xxxg-tp106646p106944.html


akashrn5 commented on a change in pull request #4102:
URL: https://github.com/apache/carbondata/pull/4102#discussion_r595866555



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala
##########
@@ -93,6 +93,9 @@ object Compactor {
             segmentToSegmentTimestampMap, null,
             forceAccessSegment, isCompactionCall = true,
             isLoadToFailedSISegments = false)
+        if (segmentLocks.isEmpty) {

Review comment:
       please add a log here saying that the loading of compacted segment into SI table failed, couldn't acquire segment lock on the specific segment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]