Posted by
GitBox on
Apr 21, 2021; 8:38am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-3988-WIP-Clean-index-files-when-clean-filesd-tp102150p107745.html
Indhumathi27 commented on a change in pull request #3988:
URL:
https://github.com/apache/carbondata/pull/3988#discussion_r617317931##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/mergeindex/CarbonIndexFileMergeTestCaseWithSI.scala
##########
@@ -215,52 +238,59 @@ class CarbonIndexFileMergeTestCaseWithSI
s"'GLOBAL_SORT_PARTITIONS'='20')")
sql("CREATE INDEX nonindexmerge_index4 on table nonindexmerge (name) AS 'carbondata'")
val rows = sql("""Select count(*) from nonindexmerge""").collect()
- assert(getIndexFileCount("default_nonindexmerge", "0") == 20)
- assert(getIndexFileCount("default_nonindexmerge", "1") == 20)
- assert(getIndexFileCount("default_nonindexmerge", "2") == 20)
- assert(getIndexFileCount("default_nonindexmerge", "3") == 20)
- assert(getIndexFileCount("default_nonindexmerge_index4", "0") == 20)
- assert(getIndexFileCount("default_nonindexmerge_index4", "1") == 20)
- assert(getIndexFileCount("default_nonindexmerge_index4", "2") == 20)
- assert(getIndexFileCount("default_nonindexmerge_index4", "3") == 20)
+ assert(CarbonTestUtil.getIndexFileCount("default_nonindexmerge", "0",
Review comment:
You can create getIndexFileCount with tablename and segment and call existing getIndexFileCount method, with extension as null for INDEX_FILE_EXT and refactor the testclass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]