Posted by
GitBox on
Apr 23, 2021; 8:10am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4124-WIP-Fix-inverted-index-query-issue-andn-tp107810p107836.html
ajantha-bhat commented on a change in pull request #4124:
URL:
https://github.com/apache/carbondata/pull/4124#discussion_r619026501##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/columnar/ByteArrayColumnWithRowId.java
##########
@@ -42,7 +42,7 @@ public short getRowId() {
@Override
public int compareTo(ByteArrayColumnWithRowId o) {
return UnsafeComparer.INSTANCE
- .compareTo(column, 2, column.length - 2, o.column, 2, o.column.length - 2);
+ .compareTo(column, 0, column.length, o.column, 0, o.column.length);
Review comment:
As discussed, I think no dictionary string column comparison will go wrong after this change. no dictionary string to be alphabetically sorted we need to ignore L in LV. so please test and handle compare logic based on the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]