Posted by
GitBox on
Apr 23, 2021; 3:06pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4124-WIP-Fix-inverted-index-query-issue-andn-tp107810p107852.html
ShreelekhyaG commented on a change in pull request #4124:
URL:
https://github.com/apache/carbondata/pull/4124#discussion_r619294183##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/columnar/ByteArrayColumnWithRowId.java
##########
@@ -42,7 +42,7 @@ public short getRowId() {
@Override
public int compareTo(ByteArrayColumnWithRowId o) {
return UnsafeComparer.INSTANCE
- .compareTo(column, 2, column.length - 2, o.column, 2, o.column.length - 2);
+ .compareTo(column, 0, column.length, o.column, 0, o.column.length);
Review comment:
yes, this flow will be used for string types only. I have added a check for the dictionary and handled the compare logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]