[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4124: [CARBONDATA-4173][CARBONDATA-4174] Fix inverted index query issue and handle exception for desc column

Posted by GitBox on Apr 23, 2021; 5:45pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4124-WIP-Fix-inverted-index-query-issue-andn-tp107810p107856.html


ajantha-bhat commented on a change in pull request #4124:
URL: https://github.com/apache/carbondata/pull/4124#discussion_r619395321



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/columnar/ByteArrayColumnWithRowId.java
##########
@@ -51,11 +59,12 @@ public boolean equals(Object obj) {
       return false;
     }
     ByteArrayColumnWithRowId o = (ByteArrayColumnWithRowId)obj;
-    return Arrays.equals(column, o.column) && rowId == o.rowId;
+    return Arrays.equals(column, o.column) && rowId == o.rowId
+        && isNoDictionary == o.isNoDictionary;

Review comment:
       Do we really need to consider `isNoDictionary` here ? when it will be not equal? I think as it is a comparison of data within a column (that too within a column page), this condition might always be true.
   
   If not required, remove from equals and hashcode




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]