[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4124: [CARBONDATA-4173][CARBONDATA-4174] Fix inverted index query issue and handle exception for desc column

Posted by GitBox on Apr 26, 2021; 7:09am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4124-WIP-Fix-inverted-index-query-issue-andn-tp107810p107866.html


ShreelekhyaG commented on a change in pull request #4124:
URL: https://github.com/apache/carbondata/pull/4124#discussion_r619991184



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/columnar/ByteArrayColumnWithRowId.java
##########
@@ -51,11 +59,12 @@ public boolean equals(Object obj) {
       return false;
     }
     ByteArrayColumnWithRowId o = (ByteArrayColumnWithRowId)obj;
-    return Arrays.equals(column, o.column) && rowId == o.rowId;
+    return Arrays.equals(column, o.column) && rowId == o.rowId
+        && isNoDictionary == o.isNoDictionary;

Review comment:
       Done. Removed.




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]