Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4121-CARBONDATA-4170-Support-dropping-of-single-tp107751p107904.html
akashrn5 commented on a change in pull request #4121:
URL:
https://github.com/apache/carbondata/pull/4121#discussion_r620188118##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/AlterTableDropColumnEventListener.scala
##########
@@ -74,23 +73,11 @@ class AlterTableDropColumnEventListener extends OperationEventListener {
val indexColumns = indexTable._2.asScala(CarbonCommonConstants.INDEX_COLUMNS).split(",")
val colSize = alterTableDropColumnModel.columns.intersect(indexColumns).size
if (colSize > 0) {
- if (colSize == indexColumns.size) {
- indexTableToDrop ++= Seq(indexTable._1)
- } else {
- sys
- .error(s"Index Table [${
- indexTable._1
- }] exists with combination of provided drop column(s) and other columns, drop " +
- s"index table & retry")
- }
+ sys
+ .error(s"Index Table [${
+ indexTable._1
+ }] contains provided drop column(s), please drop index table & retry")
Review comment:
can change to like below
`s"${column} is present in index table. Please drop the index table ${indextable._1} first and then retry the drop column operation.` . This will be more clear. See if u can improvise this also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]