[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4138: [CARBONDATA-4189] alter table validation issues

Posted by GitBox on May 20, 2021; 5:10pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-maheshrajus-opened-a-new-pull-request-4138-CARBONDATA-4189-alter-table-validation-s-tp108243p108322.html


Indhumathi27 commented on a change in pull request #4138:
URL: https://github.com/apache/carbondata/pull/4138#discussion_r636299047



##########
File path: integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -916,6 +916,10 @@ object AlterTableUtil {
         val errMsg = "LONG_STRING_COLUMNS column: " + col +
                      " is not a string datatype column"
         throw new MalformedCarbonCommandException(errMsg)
+      } else if (colSchemas.exists(x => x.getColumnName.equalsIgnoreCase(col) &&

Review comment:
       This check can be moved before previous else case and error message could be,
   Complex child column $col cannot be set as LONG_STRING_COLUMNS




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]