[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4138: [CARBONDATA-4189] alter table validation issues

Posted by GitBox on May 20, 2021; 6:46pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-maheshrajus-opened-a-new-pull-request-4138-CARBONDATA-4189-alter-table-validation-s-tp108243p108329.html


Indhumathi27 commented on a change in pull request #4138:
URL: https://github.com/apache/carbondata/pull/4138#discussion_r636377233



##########
File path: integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -911,8 +911,12 @@ object AlterTableUtil {
                        " does not exist in table. Please check the DDL."
         throw new MalformedCarbonCommandException(errorMsg)
       } else if (colSchemas.exists(x => x.getColumnName.equalsIgnoreCase(col) &&
-                                          !x.getDataType.toString
-                                            .equalsIgnoreCase("STRING"))) {
+                                        x.isComplexColumn)) {
+        val errMsg = "Complex child column " + col + " cannot be set as LONG_STRING_COLUMNS"

Review comment:
       ```suggestion
           val errMsg = s"Complex child column $col cannot be set as LONG_STRING_COLUMNS"
   ```




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]