[GitHub] [carbondata] nihal0107 commented on a change in pull request #4132: [CARBONDATA-4186] Fixed insert failure when partition column present in local sort scope

Posted by GitBox on May 27, 2021; 5:43am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-nihal0107-opened-a-new-pull-request-4132-WIP-Fixed-insert-failure-when-partition-ce-tp108122p108441.html


nihal0107 commented on a change in pull request #4132:
URL: https://github.com/apache/carbondata/pull/4132#discussion_r640303241



##########
File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java
##########
@@ -532,7 +556,7 @@ public static SortParameters createSortParameters(CarbonDataLoadConfiguration co
       parameters.setNoDictSortDataType(noDictSortAndNoSortDataTypes.get("noDictSortDataTypes"));
       parameters.setNoDictNoSortDataType(noDictSortAndNoSortDataTypes.get("noDictNoSortDataTypes"));
       // keep partition columns in the end for table spec by getting rearranged tale spec
-      TableSpec tableSpec = new TableSpec(configuration.getTableSpec().getCarbonTable(), true);
+      TableSpec tableSpec = new TableSpec(configuration.getTableSpec().getCarbonTable(), false);

Review comment:
       Rework is done and tested above-mentioned scenario. It is working fine now. @ajantha-bhat please review.




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]