Login  Register

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4098: [CARBONDATA-4143] UT with index server

Posted by GitBox on Jun 03, 2021; 6:42am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4098-WIP-UT-with-index-server-tp106489p108568.html


ShreelekhyaG commented on a change in pull request #4098:
URL: https://github.com/apache/carbondata/pull/4098#discussion_r644526559



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/test/SparkTestQueryExecutor.scala
##########
@@ -82,6 +83,15 @@ object SparkTestQueryExecutor {
       copyResourcesifNotExists(hdfsUrl, s"$integrationPath/spark/src/test/resources",
         s"$integrationPath//spark-common-cluster-test/src/test/resources/testdatafileslist.txt")
   }
+  if (System.getProperty("useIndexServer") != null || System.getenv("useIndexServer") != null) {

Review comment:
       ok

##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/test/util/CarbonFunSuite.scala
##########
@@ -44,4 +44,18 @@ private[spark] abstract class CarbonFunSuite extends FunSuite {
     }
   }
 
+  protected def test(testName : scala.Predef.String, ignoreForIndexServer: Boolean,
+                     testTags : org.scalatest.Tag*)
+                    (testFun : => Unit): Unit = {
+    if (ignoreForIndexServer) {
+      if (System.getProperty("useIndexServer") == null) {

Review comment:
       done




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]