Posted by
GitBox on
Jun 03, 2021; 11:26am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4129-WIP-alter-rename-complex-types-tp108015p108613.html
akashrn5 commented on a change in pull request #4129:
URL:
https://github.com/apache/carbondata/pull/4129#discussion_r644711580##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala
##########
@@ -1132,10 +1135,53 @@ object CarbonParserUtil {
} else if (scale < 0 || scale > 38) {
throw new MalformedCarbonCommandException("Invalid value for scale")
}
- DataTypeInfo("decimal", precision, scale)
+ DataTypeInfo(columnName, "decimal", precision, scale)
+ case _ =>
+ DataTypeInfo(columnName,
+ DataTypeConverterUtil.convertToCarbonType(dataType).getName.toLowerCase)
+ }
+ }
+
+ /**
+ * This method will return the instantiated DataTypeInfo by parsing the column
+ */
+ def parseColumn(columnName: String, dataType: DataType,
+ values: Option[List[(Int, Int)]]): DataTypeInfo = {
+ // creates parent dataTypeInfo first
+ val dataTypeName = DataTypeConverterUtil.convertToCarbonType(dataType.typeName).getName
+ val dataTypeInfo = CarbonParserUtil.parseDataType(columnName, dataTypeName.toLowerCase, values)
+ // check which child type is present and create children dataTypeInfo accordingly
+ dataType match {
+ case arrayType: ArrayType =>
+ val childType: DataType = arrayType.elementType
+ val childName = columnName + ".val"
+ val childValues = childType match {
+ case d: DecimalType => Some(List((d.precision, d.scale)))
+ case _ => None
+ }
+ val childDatatypeInfo = parseColumn(childName, childType, childValues)
+ dataTypeInfo.setChildren(List(childDatatypeInfo))
+ case structType: StructType =>
+ var childTypeInfoList: List[DataTypeInfo] = null
+ for (childField <- structType) {
+ val childType = childField.dataType
+ val childName = columnName + CarbonCommonConstants.POINT + childField.name
+ val childValues = childType match {
+ case d: DecimalType => Some(List((d.precision, d.scale)))
+ case _ => None
+ }
+ val childDatatypeInfo = CarbonParserUtil.parseColumn(childName, childType, childValues)
+ if (childTypeInfoList == null) {
+ childTypeInfoList = List(childDatatypeInfo)
+ } else {
+ childTypeInfoList = childTypeInfoList :+ childDatatypeInfo
+ }
+ }
+ dataTypeInfo.setChildren(childTypeInfoList)
case _ =>
- DataTypeInfo(DataTypeConverterUtil.convertToCarbonType(dataType).getName.toLowerCase)
}
+ // To-Do for map types
Review comment:
add jira ID here, todo should be together, else i don't think it identifies as TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]