Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4129-WIP-alter-rename-complex-types-tp108015p108738.html
akkio-97 commented on a change in pull request #4129:
URL:
https://github.com/apache/carbondata/pull/4129#discussion_r645731693##########
File path: docs/ddl-of-carbondata.md
##########
@@ -805,7 +805,7 @@ Users can specify which columns to include and exclude for local dictionary gene
2. If a column to be dropped has any Secondary index table created on them, drop column operation fails and the user will
be asked to drop the corresponding SI table first before going for actual drop.
- - #### CHANGE COLUMN NAME/TYPE/COMMENT
+ - #### change-column-name-type-comment
Review comment:
Done
##########
File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
##########
@@ -1898,6 +1898,12 @@ private CarbonCommonConstants() {
*/
public static final String POINT = ".";
+ /**
+ * POINT as a character
+ */
+ public static final char CHAR_POINT = '.';
Review comment:
used it in split method. Split in scala uses regex and not string.
I now used POINT only and converted to character
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]