[GitHub] [carbondata] maheshrajus commented on a change in pull request #4150: [CARBONDATA-4208] Wrong Exception received for complex child long string columns

Posted by GitBox on Jun 15, 2021; 11:04am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-maheshrajus-opened-a-new-pull-request-4150-CARBONDATA-4208-Wrong-Exception-receives-tp108900p108918.html


maheshrajus commented on a change in pull request #4150:
URL: https://github.com/apache/carbondata/pull/4150#discussion_r651682785



##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -3500,4 +3500,12 @@ public static void updateNullValueBasedOnDatatype(DataOutputStream dataOutputStr
       dataOutputStream.write(CarbonCommonConstants.EMPTY_BYTE_ARRAY);
     }
   }
+
+  /**
+   * returns whether column is complex column based on column name for child column
+   * @return true if column is complex
+   */
+  public static boolean isComplexColumn(String colName) {
+    return colName.contains(".val") || colName.contains(".");

Review comment:
       ok




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]