[jira] [Commented] (CARBONDATA-251) making the auto compaction as blocking call.

Posted by Akash R Nilugal (Jira) on Sep 17, 2016; 4:29pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/jira-Commented-CARBONDATA-251-making-the-auto-compaction-as-blocking-call-tp1128.html


    [ https://issues.apache.org/jira/browse/CARBONDATA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499291#comment-15499291 ]

ASF GitHub Bot commented on CARBONDATA-251:
-------------------------------------------

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/168#discussion_r79287073
 
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -623,14 +623,7 @@ object CarbonDataRDDFactory extends Logging {
               }
             }
           }
    -      if(compactionModel.isDDLTrigger) {
    -        // making this an blocking call for DDL
    -        compactionThread.run()
    -      }
    -      else {
    -        // non blocking call in case of auto compaction.
    -        compactionThread.start()
    -      }
    +    compactionThread.run()
    --- End diff --
   
    Add a comment, why run is called instead of start, future will make it concurrent.

> making the auto compaction as blocking call.
> --------------------------------------------
>
>                 Key: CARBONDATA-251
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-251
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: ravikiran
>
> making the auto compaction as blocking call.
> disabling the system level compaction lock feature.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)