Posted by
Akash R Nilugal (Jira) on
Sep 20, 2016; 7:29am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/jira-Commented-CARBONDATA-208-User-should-be-able-to-turn-on-and-off-the-STATISTIC-log-tp1254.html
[
https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505872#comment-15505872 ]
ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/176#discussion_r79549615
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -461,8 +459,15 @@ private Object getFilterPredicates(Configuration configuration) {
FilterExpressionProcessor filterExpressionProcessor,
AbsoluteTableIdentifier absoluteTableIdentifier, FilterResolverIntf resolver,
String segmentId) throws IndexBuilderException, IOException {
-
- QueryStatisticsRecorder recorder = new QueryStatisticsRecorder("");
+ String queryStatisticsRecorderInstanceType = CarbonProperties.getInstance()
--- End diff --
can we move this creation logic to the factory class?
> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
> Key: CARBONDATA-208
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-208> Project: CarbonData
> Issue Type: Bug
> Reporter: Jacky Li
> Priority: Minor
> Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it should be configurable by the user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)