Re: [DISCUSSION] Whether Carbondata should keep carbon-sql-shell script

Posted by Liang Chen-2 on Jun 07, 2017; 3:21am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/DISCUSSION-Whether-Carbondata-should-keep-carbon-spark-shell-script-tp14077p14081.html

Hi

correct the file name, should be : ./bin/carbon-spark-sql and
./bin/carbon-spark-shell.

Are you suggesting removing both file or only carbon-spark-shell ?

Regards
Liang

2017-06-07 0:24 GMT+08:00 Erlu Chen <[hidden email]>:

> Hi community,
>
> Recently, I viewed the implementation of carbon-sql-shell and tried to
> understand the function of this script.
>
> This script just wrap some steps and provide existing CarbonContext or
> CarbonSession for users  to interact with Carbondata.
>
> I hold my opinion that we can remove this script because this script is
> useless except providing a existing CarbonContext or CarbonSession.
>
> Reasons as below:
> 1. Carbondata now has integration spark1.x and spark2.x, Carbondata should
> refactor carbon-spark-shell every time when spark update.
> 2. After run this script, it will generate redundant folders in project and
> user may forget to remove these folders.
> 3. The CarbonContext or CarbonSession may be created with store path and
> metastore path which user may not want.
>
> I just share my idea about this, we can discuss about whether we should
> keep
> this script.
>
> Thanks.
>
> Regards.
> Chenerlu.
>
>
>
>
>
>
>
> --
> View this message in context: http://apache-carbondata-dev-
> mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-
> Whether-Carbondata-should-keep-carbon-sql-shell-script-tp14077.html
> Sent from the Apache CarbonData Dev Mailing List archive mailing list
> archive at Nabble.com.
>