[discussion]When table properties is repeated it only set the last one

Posted by Zhangshunyu on Sep 28, 2016; 7:11am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/discussion-When-table-properties-is-repeated-it-only-set-the-last-one-tp1539.html

When table properties is repeated it only set the last one, for example,

CREATE TABLE IF NOT EXISTS carbontable
(ID Int, date Timestamp, country String,
name String, phonetype String, serialname String, salary Int)
STORED BY 'carbondata'
TBLPROPERTIES('DICTIONARY_EXCLUDE'='country','DICTIONARY_INCLUDE'='ID',
'DICTIONARY_EXCLUDE'='phonetype', 'DICTIONARY_INCLUDE'='salary')

As we use map to store the properties, only salary is set to DICTIONARY_INCLUDE and only phonetype is set to DICTIONARY_EXCLUDE.

I think we can fix this pbm in 2 way:

1. Do restrict syntax check: When tblProperty is repeated, throw an MalformedCarbonCommandException to tell the user that table properties is repeated, so that the user would not perform error operation.
2. Let the properties recombining, and set the table properties for all the specified columns.

What's your opinion?