Posted by
Akash R Nilugal (Jira) on
Oct 07, 2016; 8:35am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/jira-Commented-CARBONDATA-233-bad-record-logger-support-for-non-parseable-numeric-and-timestamp-data-tp1651.html
[
https://issues.apache.org/jira/browse/CARBONDATA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554533#comment-15554533 ]
ASF GitHub Bot commented on CARBONDATA-233:
-------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/148#discussion_r82348806
--- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java ---
@@ -853,8 +873,10 @@ private String getCarbonLocalBaseStoreLocation() {
private Object[] process(Object[] r) throws RuntimeException {
try {
+ Object[] actualRow = new Object[r.length];
+ System.arraycopy(r, 0, actualRow, 0, r.length);
--- End diff --
Can't we avoid this object[] instance and arraycopy?
I guess we can merge `changeNullValueToNullString` and `populateOutputRow` and avoid arraycopy.
> bad record logger support for non parseable numeric and timestamp data
> ----------------------------------------------------------------------
>
> Key: CARBONDATA-233
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-233> Project: CarbonData
> Issue Type: Improvement
> Reporter: Mohammad Shahid Khan
> Assignee: Mohammad Shahid Khan
>
> bad record logger support for non parseable numeric and timestamp data
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)