[jira] [Commented] (CARBONDATA-306) block size info should be show in Desc Formatted and executor log
Posted by
Akash R Nilugal (Jira) on
Oct 12, 2016; 3:14pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/jira-Commented-CARBONDATA-306-block-size-info-should-be-show-in-Desc-Formatted-and-executor-log-tp1805.html
[
https://issues.apache.org/jira/browse/CARBONDATA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569003#comment-15569003 ]
ASF GitHub Bot commented on CARBONDATA-306:
-------------------------------------------
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/230#discussion_r83028164
--- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
@@ -252,6 +252,9 @@ private static long getMaxOfBlockAndFileSize(long blockSize, long fileSize) {
if (remainder > 0) {
maxSize = maxSize + HDFS_CHECKSUM_LENGTH - remainder;
}
+ LOGGER.info("The configured block size is " + blockSize + " byte, " +
--- End diff --
Suggest to have the `blockSize` convert to a proper number before logging it, otherwise it is hard to check this value by human
> block size info should be show in Desc Formatted and executor log
> -----------------------------------------------------------------
>
> Key: CARBONDATA-306
> URL:
https://issues.apache.org/jira/browse/CARBONDATA-306> Project: CarbonData
> Issue Type: Improvement
> Reporter: Jay
> Priority: Minor
>
> when run desc formatted command, the table block size should be show, as well as in executor log when run load command
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)