Re: please vote and comment: remove thrift solution

Posted by Liang Chen on Oct 24, 2016; 8:39am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2254.html

Hi

I prefer to the new solution for fixing thrift issues:Directly use java code ( thrift compiler compile carbondata format files to java  code) to build, then users don't need to do any thrift installation.

+1 for new solution.

Regards
Liang

QiangCai wrote

Hi

Currently, There are two typical Thrift issues:

1.Users want to directly build Apache CarbonData, don’t need to install Thrift in advance. For example:

Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build (not your fault - I did not have thrift
installed and didn't have the time & patience to install it).

2.Need to fix Apache Jenkins CI issues, as below:

[ERROR] Failed to execute goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile (generate-thrift-java) on project carbondata-format: thrift did not exit cleanly. Review output for more information. -> [Help 1]

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile (generate-thrift-java) on project carbondata-format: thrift did not exit cleanly. Review output for more information.

For solving the above mentioned Thrift issues, i would like to propose one solution: Directly use java code ( thrift compiler compile carbondata format files to java  code) to build, then users don't need to do any thrift installation.

please vote and comment :

To continue use the current manual install method to build

or

To directly use java code which be generated by thrift compiler to build