Re: please vote and comment: remove thrift solution

Posted by Vimal Das Kammath on Oct 24, 2016; 9:02am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2255.html

+1 for directly using java code to build.
At the same time, we should have the CI infrastructure to ensure that the
.thrift files and the generated source code are always in sync.

Regards
Vimal

On Mon, Oct 24, 2016 at 2:09 PM, Liang Chen <[hidden email]> wrote:

> Hi
>
> I prefer to the new solution for fixing thrift issues:Directly use java
> code
> ( thrift compiler compile carbondata format files to java  code) to build,
> then users don't need to do any thrift installation.
>
> +1 for new solution.
>
> Regards
> Liang
>
> QiangCai wrote
> > Hi
> >
> > Currently, There are two typical Thrift issues:
> >
> > 1.Users want to directly build Apache CarbonData, don’t need to install
> > Thrift in advance. For example:
> >
> > Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
> > (not your fault - I did not have thrift
> > installed and didn't have the time & patience to install it).
> >
> > 2.Need to fix Apache Jenkins CI issues, as below:
> >
> > [ERROR] Failed to execute goal
> > org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information. -> [Help 1]
> >
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute
> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information.
> >
> > For solving the above mentioned Thrift issues, i would like to propose
> one
> > solution: Directly use java code ( thrift compiler compile carbondata
> > format files to java  code) to build, then users don't need to do any
> > thrift installation.
> >
> > please vote and comment :
> >
> > To continue use the current manual install method to build
> >
> > or
> >
> > To directly use java code which be generated by thrift compiler to build
>
>
>
>
>
> --
> View this message in context: http://apache-carbondata-
> mailing-list-archive.1130556.n5.nabble.com/please-vote-and-
> comment-remove-thrift-solution-tp2253p2254.html
> Sent from the Apache CarbonData Mailing List archive mailing list archive
> at Nabble.com.
>