Re: Please vote and advise on building thrift files

Posted by sraghunandan on Nov 17, 2016; 1:12am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p2953.html

I vote for pooposal 1
On Thu, 17 Nov 2016 at 12:04 AM, Liang Chen <[hidden email]> wrote:

> Hi all
>
> Please vote the below proposals or advise other better proposal on building
> thrift files.
>
>
>
> ---------------------------------------------------------------------------------------
>
> CarbonData is file format and introduce Apache thrift for supporting
> multiple languages and any language can read the file format written by
> thrift.
>
>
>
> Following are 2 proposals to build thrift file
>
>
>
> *Proposal 1:* provide dependency in maven pom file.
>
> For people(IPMC,PPMC, and others)who want to verify release need to install
> thrift for building with this command "mvn clean -Pbuild-with-format
> install".
>
> For general users: no need to install thrift and build with command "mvn
> clean install", because the dependency provided in maven pom file(already
> uploaded the compiled format jar to snapshot repository for dev, and to
> release repository once released)
>
>
>
> pros: use jar dependency, easy to manage.
>
> cons: only verify release need to install thrift.
>
>
>
> *Proposal 2: *generate thrift java code and add to system for building
> without thrift installation
>
>
>
> For people(IPMC,PPMC,and others) who want to verify release,no need to
> install thrift and build with command "mvn clean install".
>
>
> pros: no thrift installation for verify release
>
> cons: introduce around 10k java code to system, for every language(like
> C++),need introduce more code.
>
>
> Regards
> Liang
>