Login  Register

Re: Please vote and advise on building thrift files

Posted by Venkata Gollamudi on Nov 21, 2016; 2:32am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/Please-vote-and-advise-on-building-thrift-files-tp2952p3047.html

+1 for solution 1.

Solution 2 would be good if generated code is very less. But Carbondata
thrift generated code is around 10k, which is more. Also later has to
support C++ interface also.

On Sun, Nov 20, 2016, 10:53 PM Fu Chen <[hidden email]> wrote:

> +1 for Proposal 1
> > 在 2016年11月18日,上午11:58,sujith chacko <[hidden email]> 写道:
> >
> > +1 for first approach.
> >
> > On Nov 17, 2016 9:58 AM, "金铸" <[hidden email]> wrote:
> >
> >> +1 for proposal 1
> >>
> >>
> >> 在 2016/11/17 12:13, 邢冰 写道:
> >>
> >>> +1 for proposal 1
> >>>
> >>> thx
> >>>
> >>>
> >>>
> >>>
> >>> 发自网易邮箱大师
> >>> On 11/17/2016 12:09, Ravindra Pesala wrote:
> >>> +1 for proposal 1
> >>>
> >>> On 17 November 2016 at 08:23, Xiaoqiao He <[hidden email]> wrote:
> >>>
> >>> +1 for proposal 1.
> >>>>
> >>>> On Thu, Nov 17, 2016 at 10:31 AM, ZhuWilliam <[hidden email]>
> >>>> wrote:
> >>>>
> >>>> +1 for proposal 1 .
> >>>>>
> >>>>> Auto generated code should not be added to project. Also most the of
> >>>>> time
> >>>>> ,people who dive into carbondata may not touch format code.
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> View this message in context: http://apache-carbondata-
> >>>>> mailing-list-archive.1130556.n5.nabble.com/Please-vote-and-
> >>>>> advise-on-building-thrift-files-tp2952p2957.html
> >>>>> Sent from the Apache CarbonData Mailing List archive mailing list
> >>>>> archive
> >>>>> at Nabble.com.
> >>>>>
> >>>>>
> >>>
> >>> --
> >>> Thanks & Regards,
> >>> Ravi
> >>>
> >>
> >>
> >>
> >>
> >> ------------------------------------------------------------
> >> ---------------------------------------
> >> Confidentiality Notice: The information contained in this e-mail and any
> >> accompanying attachment(s)
> >> is intended only for the use of the intended recipient and may be
> >> confidential and/or privileged of
> >> Neusoft Corporation, its subsidiaries and/or its affiliates. If any
> reader
> >> of this communication is
> >> not the intended recipient, unauthorized use, forwarding, printing,
> >> storing, disclosure or copying
> >> is strictly prohibited, and may be unlawful.If you have received this
> >> communication in error,please
> >> immediately notify the sender by return e-mail, and delete the original
> >> message and all copies from
> >> your system. Thank you.
> >> ------------------------------------------------------------
> >> ---------------------------------------
> >>
>
>