Re: [VOTE] Apache CarbonData 0.1.0-incubating release

Posted by Henry Saputra on Aug 23, 2016; 6:15am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/Re-VOTE-Apache-CarbonData-0-1-0-incubating-release-tp377p394.html

RAT check seems to pass if you have 2 license headers.

More important question is that, does CarbonData team copy some classes and
interfaces defintions from other projects like OpenCV [1] ?

It is ASF license, but I am wondering why you need to copy instead of just
OpenCV declaration instead?

- Henry

[1]
https://github.com/apache/incubator-carbondata/blob/6a2c504fd06ee21ac371c5aa1956b156a159be67/integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelper.java#L42



On Mon, Aug 22, 2016 at 11:09 PM, Jean-Baptiste Onofré <[hidden email]>
wrote:

> FYI,
>
> the vote didn't pass at IPMC due to bad license header in the following
> files:
>
> 1. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/DataPartitioner.java
> 2. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/CSVFilePartitioner.java
> 3. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/DefaultLoadBalancer.java
> 4. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/PartitionImpl.java
> 5. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/impl/QueryPartitionHelper.java
> 6. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/api/Partition.java
> 7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
> 8. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/CSVParser.java
> 9. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/CSVReader.java
> 10. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/CSVWriter.java
> 11. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/ResultSetHelper.java
> 12. ./integration/spark/src/main/java/org/apache/carbondata/spar
> k/partition/reader/ResultSetHelperService.java
>
> They contain:
>
> /**
>  * Copyright Notice
>  * =====================================
>  * This file contains proprietary information of
>  * Huawei Technologies India Pvt Ltd.
>  * Copying or reproduction without prior written approval is prohibited.
>  * Copyright (c) 1997
>  * =====================================
>  */
>
> This file [7] also has a similar issue copyright 2012.
>
> So, I'm cancel the release and prepare a PR with the fixes (on branch-0.1
> and master). Then I will cut a new release for vote.
>
> Regards
> JB
>
> On 08/19/2016 08:57 PM, Jean-Baptiste Onofré wrote:
>
>> Hi all,
>>
>> I submit the first CarbonData release to your vote.
>>
>> Release Notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12320220&version=12337895
>>
>>
>> Staging Repository:
>> https://repository.apache.org/content/repositories/orgapache
>> carbondata-1000/
>>
>>
>> Git Tag:
>> carbondata-0.1.0-incubating
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Don't approve the release (please provide specific comments)
>>
>> This vote will be open for at least 72 hours.
>>
>> If this vote passes (we need at least 3 binding votes, meaning three
>> votes from the PPMC), I will forward to [hidden email] for
>> the IPMC votes.
>>
>> Thanks
>> Regards
>> JB
>>
>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>