CarbonWriterBuild issue

Posted by Jacky Li on Sep 13, 2018; 2:11am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/CarbonWriterBuild-issue-tp62361.html

Hi Dev,

I observed that we have added many buildXXXWriter in CarbonWriterBuilder in SDK, but all of them is just different parameter combination. I think it is better to add those parameter by withXXX function, which complies to Builder pattern. Otherwise it is hard to maintain if we keep adding these parameter and new build functions.
Any suggestion on this?

public CarbonWriter buildWriterForCSVInput(Schema schema, Configuration configuration)

public CarbonWriter buildThreadSafeWriterForCSVInput(Schema schema, short numOfThreads, Configuration configuration)

public CarbonWriter buildWriterForAvroInput(org.apache.avro.Schema avroSchema, Configuration configuration)

public CarbonWriter buildThreadSafeWriterForAvroInput(org.apache.avro.Schema avroSchema, short numOfThreads, Configuration configuration)

public JsonCarbonWriter buildWriterForJsonInput(Schema carbonSchema, Configuration configuration)

public JsonCarbonWriter buildThreadSafeWriterForJsonInput(Schema carbonSchema, short numOfThreads, Configuration configuration)


Regards,
Jacky