Re: [Discussion] Refactor dynamic configuration
Posted by
xubo245 on
Nov 24, 2018; 3:58am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/Discussion-Refactor-dynamic-configuration-tp67057p69103.html
I rasie a PR for it and write a
demo:
https://github.com/apache/carbondata/pull/2914Please check it.
1. Optimize the String implementation, we can provide property builder for it, then can use it in CarbonCommonConstant to replace current String implementation.
For example:
public static final Property CSV_READ_BUFFER_SIZE = Property.buildIntProperty()
.name("carbon.csv.read.buffersize.byte")
.defaultValue(1048576)
.minValue(10240)
.maxValue(10485760)
.doc("CSV_READ_BUFFER_SIZE, default value is 1mb." +
"min value for csv read buffer size, 10 kb." +
"max value for csv read buffer size, 10 mb")
.build();
2.add interface for Property:
org.apache.carbondata.core.util.CarbonProperties#addProperty(org.apache.carbondata.core.util.Property, java.lang.String)
org.apache.carbondata.core.util.CarbonProperties#addProperty(org.apache.carbondata.core.util.Property)
org.apache.carbondata.core.util.CarbonProperties#getProperty(org.apache.carbondata.core.util.Property, java.lang.String)
If the demo is ok, I will change other properties in this PR
--
Sent from:
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/