[GitHub] [carbondata] IceMimosa opened a new pull request #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types

[GitBox]

IceMimosa opened a new pull request #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569
 
 
   Follow up CARBONDATA-3628
   
   ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

IceMimosa commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-572169964
 
 
   Add this please.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-572172339
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1544/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

IceMimosa commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-572193904
 
 
   Fix style

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

IceMimosa commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-572208427
 
 
   Fix style

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-572241135
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1547/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-574542174
 
 
   @IceMimosa This PR is ok, can you add a brief description to this PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

IceMimosa commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-574555233
 
 
   @jackylk Done, thanks for reviewing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569#issuecomment-575223163
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3569: [CARBONDATA-3657]Support alter hive table add columns with complex types
URL: https://github.com/apache/carbondata/pull/3569
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services