[GitHub] [carbondata] Indhumathi27 opened a new pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type

[GitBox]

Indhumathi27 opened a new pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630
 
 
   
   
    ### Why is this PR needed?
    Timeseries query with timeseries column as date,is throwing parsing exception after rollup, because while forming sql for cast expression, it is taking wrong attribute name
   
    ### What changes were proposed in this PR?
   If query is rolled up for date, then take attribute name for forming sql for cast expression.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-589517672
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/380/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-589539317
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2082/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591323104
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/493/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591358248
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2192/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591388423
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/499/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591419578
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2198/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591801271
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/507/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591824672
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2206/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591865763
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/509/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-591901593
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2208/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#discussion_r386100218
 
 

 ##########
 File path: mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Utils.scala
 ##########
 @@ -590,6 +591,21 @@ object Utils extends PredicateHelper {
     }
   }
 
+  /**
+   * transform cast expression to change it's child attribute reference name to lower case
+   */
+  def getTransformedCastExpression(cast: Cast): Expression = {
+    cast.transform {
+      case attr: AttributeReference =>
+        CarbonToSparkAdapter.createAttributeReference(attr.name.toLowerCase,
 
 Review comment:
   move `attr.name.toLowerCase` to next line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on a change in pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#discussion_r386196837
 
 

 ##########
 File path: mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Utils.scala
 ##########
 @@ -590,6 +591,21 @@ object Utils extends PredicateHelper {
     }
   }
 
+  /**
+   * transform cast expression to change it's child attribute reference name to lower case
+   */
+  def getTransformedCastExpression(cast: Cast): Expression = {
+    cast.transform {
+      case attr: AttributeReference =>
+        CarbonToSparkAdapter.createAttributeReference(attr.name.toLowerCase,
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-593222868
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/553/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630#issuecomment-593242743
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2252/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3630: [CARBONDATA-3715]Fix Timeseries Query Rollup failure for timeseries column of Date type
URL: https://github.com/apache/carbondata/pull/3630
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services