akashrn5 commented on a change in pull request #3735:
URL:
https://github.com/apache/carbondata/pull/3735#discussion_r419871337##########
File path: docs/index/lucene-index-guide.md
##########
@@ -83,28 +84,28 @@ It will show all Indexes created on main table.
When loading data to main table, lucene index files will be generated for all the
index_columns(String Columns) given in CREATE statement which contains information about the data
location of index_columns. These index files will be written inside a folder named with index name
-inside each segment folders.
+inside each segment folder.
-A system level configuration carbon.lucene.compression.mode can be added for best compression of
+A system level configuration `carbon.lucene.compression.mode` can be added for best compression of
lucene index files. The default value is speed, where the index writing speed will be more. If the
value is compression, the index file size will be compressed.
## Querying data
As a technique for query acceleration, Lucene indexes cannot be queried directly.
-Queries are to be made on main table. when a query with TEXT_MATCH('name:c10') or
+Queries are to be made on main table. When a query with TEXT_MATCH('name:c10') or
Review comment:
```suggestion
Queries are to be made on the main table. When a query with TEXT_MATCH('name:c10') or
```
##########
File path: docs/index/index-management.md
##########
@@ -51,15 +51,15 @@ Currently, there are 3 Index implementations in CarbonData.
There are two kinds of management semantic for Index.
-1. Automatic Refresh: Create index without `WITH DEFERRED REBUILD` in the statement, which is by default.
-2. Manual Refresh: Create index with `WITH DEFERRED REBUILD` in the statement
+1. Automatic Refresh: Create index without `WITH DEFERRED REFRESH` in the statement, which is by default.
+2. Manual Refresh: Create index with `WITH DEFERRED REFRESH` in the statement
Review comment:
please rewrite the 1 and 2 point for manual and automatic refresh, its not completely meaningfull.
##########
File path: docs/index/index-management.md
##########
@@ -78,7 +78,7 @@ We do recommend you to use this management for index.
### Manual Refresh
-When user creates a index specifying manual refresh semantic, the index is created with status *disabled* and query will NOT use this index until user can issue REFRESH INDEX command to build the index. For every REFRESH INDEX command, system will trigger a full rebuild of the index. After rebuild is done, system will change index status to *enabled*, so that it can be used in query rewrite.
+When user creates a index specifying manual refresh semantic, the index is created with status *disabled* and query will NOT use this index until user can issue REFRESH INDEX command to build the index. For every REFRESH INDEX command, system will trigger a full refresh of the index. After a refresh is done, system will change index status to *enabled*, so that it can be used in query rewrite.
Review comment:
` After a refresh is done` to `Once the refresh operation is finished`
##########
File path: docs/mv-guide.md
##########
@@ -334,10 +334,10 @@
```
Then, the above query can be rolled up from materialized view 'agg_sales', by adding hour
- level time series aggregation on minute level aggregation. Users can fire explain command
- to check if query is rolled up from existing materialized view.
+ level time series aggregation on minute level aggregation. Users can fire the EXPLAIN command
Review comment:
put EXPLAIN in the quotes of code
##########
File path: docs/mv-guide.md
##########
@@ -300,19 +300,19 @@
granularity provided during creation and stored on each segment.
**NOTE**:
- 1. Single select statement cannot contain time series udf(s) neither with different granularity
+ 1. Single select statements cannot contain time series udf(s) neither with different granularity
Review comment:
i think this change is not required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
