[GitHub] [carbondata] Indhumathi27 opened a new pull request #3823: [WIP]Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 opened a new pull request #3823: [WIP]Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox

Indhumathi27 opened a new pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823


   
   
    ### Why is this PR needed?
    Issue 1:
   Queries having implicitCastInputTypes expressions is not hitting mv when expression is provided in Upper case
   Issue 2:
   MV document does not have info for SHOW MATERIALIZED VIEWS command
   
    ### What changes were proposed in this PR?
   Solution 1:
   Transform castOrImplicitCastExp expression to change it's child attribute reference name to lower case while matching subsumer and subsume
   
   Solution 2:
   Added document for SHOW MATERIALIZED VIEWS command
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3823: [WIP]Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox

CarbonDataQA1 commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-653640340


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3299/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3823: [WIP]Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-653640485


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1562/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #3823: [CARBONDATA-3890] Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-655574854


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3823: [CARBONDATA-3890] Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-655649476


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3328/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3823: [CARBONDATA-3890] Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-655652895


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1588/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #3823: [CARBONDATA-3890] Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-656027397


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on pull request #3823: [CARBONDATA-3890] Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

QiangCai commented on pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823#issuecomment-656606159


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3823: [CARBONDATA-3890] Fix MV case sensitive issues with ImplicitCastInputTypes and Add Doc for Show MV

GitBox
In reply to this post by GitBox

asfgit closed pull request #3823:
URL: https://github.com/apache/carbondata/pull/3823


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]