[GitHub] [carbondata] Karan980 opened a new pull request #3974: [Carbondata-3999] Fix permission issue of indexServerTmp directory

[GitBox]

Karan980 opened a new pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974


    ### Why is this PR needed?
   When dir "/indexservertmp" is not existing,then select query with indexserver will create a dir "/indexservertmp/[queryid]" with permission 755,and the permission of dir "/indexservertmp" is also 755,it will cause permission issue.
   
   
    ### What changes were proposed in this PR?
   When select query with indexserver,first check if the dir "/indexservertmp" is existing,and if not,then create dir "/indexservertmp" with permission 777
   
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706011556


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2593/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706011857


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4343/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706061668


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706110498


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4346/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706111654


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2596/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706061668


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-706011556






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure commented on a change in pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#discussion_r503924292



##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -3250,14 +3250,14 @@ public static String getIndexServerTempPath() {
   public static CarbonFile createTempFolderForIndexServer(String queryId)
           throws IOException {
     final String path = getIndexServerTempPath();
+    if (!FileFactory.isFileExist(path)) {
+      // Create the new index server temp directory if it does not exist
+      LOGGER.info("Creating Index Server temp folder:" + path);
+      FileFactory
+              .createDirectoryAndSetPermission(path,
+                      new FsPermission(FsAction.ALL, FsAction.ALL, FsAction.ALL));

Review comment:
       The code format is stranage




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708603224


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4443/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708610112


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2690/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708623745


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708690166


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2692/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708693056


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4445/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708897384


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708937365


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4453/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-708943444


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2699/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Karan980 commented on a change in pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#discussion_r505237702



##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -3250,14 +3250,14 @@ public static String getIndexServerTempPath() {
   public static CarbonFile createTempFolderForIndexServer(String queryId)
           throws IOException {
     final String path = getIndexServerTempPath();
+    if (!FileFactory.isFileExist(path)) {
+      // Create the new index server temp directory if it does not exist
+      LOGGER.info("Creating Index Server temp folder:" + path);
+      FileFactory
+              .createDirectoryAndSetPermission(path,
+                      new FsPermission(FsAction.ALL, FsAction.ALL, FsAction.ALL));

Review comment:
       Fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

kunal642 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-713299839


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3974:
URL: https://github.com/apache/carbondata/pull/3974#issuecomment-713365481


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4564/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]