[GitHub] [carbondata] Kejian-Li opened a new pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

classic Classic list List threaded Threaded
29 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox

QiangCai commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-704778260


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

QiangCai commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-704779979


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai edited a comment on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

QiangCai edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-704778260


   LGTM, but CI didn't run for 2.3.4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-704842487


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2572/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-704843056


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4322/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-705383989


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

asfgit closed pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

akashrn5 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-705383989


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

GitBox
In reply to this post by GitBox

asfgit closed pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12