[GitHub] [carbondata] Kejian-Li opened a new pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

[GitBox]

Kejian-Li opened a new pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964


   ### Why is this PR needed?
   
   Retrycount and retryInterval of compactLock and updateLock is fixed as "3" when they try to get lcok, default values of these two parameters is exactly "3", therefore, it is neccessary to be fixed in code, it is also good to allow users to configure them in the carbon.properties by removing them.
   
    ### What changes were proposed in this PR?
   
   Removed the parameters of compactLock and updateLock when they try to get lock.
   Besides, I made some obvious but trivial changes and modified or added some testcases.
   
    ### Does this PR introduce any user interface change?
   
    - No
   
    ### Is any new testcase added?
   
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700713068


   @marchpure please help review this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700716620


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4272/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312


   Change the PR Title to 'Support Lock configuration can be configured in Update and Delete'


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312


   Change the PR Title to 'Support Lock Configuration can be configured in Update and Delete'


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312


   Change the PR Title to 'Support Lock configuration can be configured in Update and Delete'


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700719022


   > Change the PR Title to 'Support Lock Configuration can be configured in Update and Delete'
   
   Ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700719957


   In description:
   
   it is neccessary to be fixed in code
   => it is not neccessary to be fixed in code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700720893


   Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700722195


   > Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete"
   
   
   
   > Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete"
   
   Ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Kejian-Li edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700722195


   > Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete"
   
   Ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700803544


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2528/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700804521


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4273/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700805019


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Klaus-xjp commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701105544


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Zhangshunyu commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701106628


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

QiangCai commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701213375


   please check the following files.
   CarbonDataRDDFactory 977 line
   CarbonAlterTableCompactionCommand 324 line


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701243192


   > please check the following files.
   > CarbonDataRDDFactory 977 line
   > CarbonAlterTableCompactionCommand 324 line
   
   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701346331


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2537/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701347623


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4282/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]