[GitHub] [carbondata] LiShuMing opened a new pull request #3632: [CARBONDATA-3717] Fix inconsistent configs in docs

[GitBox]

LiShuMing opened a new pull request #3632: [CARBONDATA-3717] Fix inconsistent configs in docs
URL: https://github.com/apache/carbondata/pull/3632
 
 
    ### Why is this PR needed?
   
    Now there are more and more configs in CarbonData(maybe is too many that is hard to maintain).
   
   
   
   I found a lot of confusing configs when I was using Carbon:
   ```
   - `table_block_size` -> `table_blocksize`
   - `sort.inmemory.size.in.mb` -> `sort.inmemory.size.inmb`
   - unused config(useless):
     - carbon.number.of.cores
     - carbon.graph.rowset.size
     - carbon.enableXXHash
     - ....
    ```
    ### What changes were proposed in this PR?
   - Fix wrong config docs;
   - Remove unused/meaningless config docs;
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3632: [CARBONDATA-3717] Fix inconsistent configs in docs
URL: https://github.com/apache/carbondata/pull/3632#issuecomment-589625412
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/390/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3632: [CARBONDATA-3717] Fix inconsistent configs in docs
URL: https://github.com/apache/carbondata/pull/3632#issuecomment-589651892
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2091/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3632: [CARBONDATA-3717] Fix inconsistent configs in docs
URL: https://github.com/apache/carbondata/pull/3632#discussion_r382909516
 
 

 ##########
 File path: docs/zh_cn/CarbonData与商业列存DB性能对比.md
 ##########
 @@ -89,7 +89,6 @@ LIMIT 5000
 | CarbonData主要配置                   | 参数值 | 描述                                                         |
 | ------------------------------------ | ------ | ------------------------------------------------------------ |
 | carbon.inmemory.record.size          | 480000 | 查询每个表需要加载到内存的总行数。                           |
-| carbon.number.of.cores               | 4      | carbon查询过程中并行扫描的线程数。                           |
 
 Review comment:
   nice catch.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3632: [CARBONDATA-3717] Fix inconsistent configs in docs
URL: https://github.com/apache/carbondata/pull/3632#issuecomment-589951982
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3632: [CARBONDATA-3717] Fix inconsistent configs in docs
URL: https://github.com/apache/carbondata/pull/3632
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services