[GitHub] [carbondata] QiangCai opened a new pull request #3592: [Refactory] merge all spark-related modules into a spark module

[GitBox]

CarbonDataQA1 commented on issue #3592: [Refactory] merge all spark-related modules into a spark module
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-588716662
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2071/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3592: [Refactory] merge all spark-related modules into a spark module
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-588718285
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-588803736
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/370/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-588805878
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2072/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-588929191
 
 
   Build Failed  with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/371/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-588968867
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2073/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589196062
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/373/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589228525
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2075/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589350030
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/375/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589393213
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2077/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#discussion_r382410962
 
 

 ##########
 File path: datamap/bloom/pom.xml
 ##########
 @@ -1,82 +0,0 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0"
 
 Review comment:
   I think now it is delete and add insted of move. we should use git move and git rename, so that it wont show as added , modified count

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#discussion_r382410962
 
 

 ##########
 File path: datamap/bloom/pom.xml
 ##########
 @@ -1,82 +0,0 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0"
 
 Review comment:
   @QiangCai : I think now it is delete and add instead of move. we should use git move and git rename, so that it won't show as added , modified count

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#discussion_r382417499
 
 

 ##########
 File path: datamap/bloom/pom.xml
 ##########
 @@ -1,82 +0,0 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0"
 
 Review comment:
   because when I move bloom to index/bloom. 0 files are added and modifed
   
   x-special/nautilus-clipboard
   copy
   recent:///eb75e249accc0787f48c636f5e4f795f
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#discussion_r382417499
 
 

 ##########
 File path: datamap/bloom/pom.xml
 ##########
 @@ -1,82 +0,0 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0"
 
 Review comment:
   because when I move bloom to index/bloom. 0 files are added and modified
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589902791
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/397/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589908475
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2098/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589912875
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/398/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-589916422
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2099/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590084234
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590086672
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/410/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services