[GitHub] [carbondata] QiangCai opened a new pull request #3592: [Refactory] merge all spark-related modules into a spark module

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590092714
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2111/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590131680
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/412/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590137426
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2113/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590146109
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/413/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590152972
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2114/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590156113
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590158680
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/417/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590162587
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2117/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590185253
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590189064
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/423/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590208792
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2123/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590218637
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/425/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590248002
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2125/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on a change in pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#discussion_r383185015
 
 

 ##########
 File path: datamap/bloom/pom.xml
 ##########
 @@ -11,7 +11,7 @@
   </parent>
 
   <artifactId>carbondata-bloom</artifactId>
-  <name>Apache CarbonData :: Bloom Index DataMap</name>
+  <name>Apache CarbonData :: Bloom DataMap</name>
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on a change in pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#discussion_r383185063
 
 

 ##########
 File path: datamap/lucene/pom.xml
 ##########
 @@ -11,7 +11,7 @@
   </parent>
 
   <artifactId>carbondata-lucene</artifactId>
-  <name>Apache CarbonData :: Lucene Index DataMap</name>
+  <name>Apache CarbonData :: Lucene DataMap</name>
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590258408
 
 
   I already change all to rename, but github still show a wrong summary.
   please check it as following.
   git log --shortstat
   
   commit f272b96e78351fc385cd3fab7e12f9d0f16d681c (HEAD -> refactory_module, origin/refactory_module)
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 18:23:55 2020 +0800
   
       review and fix comment
   
    24 files changed, 11 insertions(+), 47 deletions(-)
   
   commit b10ef12f912934ef20644bb881ca5290ec733aa8
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:41:40 2020 +0800
   
       fix all issue for re-factory
   
    16 files changed, 54 insertions(+), 78 deletions(-)
   
   commit 3bbe4702d384254f1d9833cb442ba6e1b504de3d
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:34:46 2020 +0800
   
       merge spark-common, spark2, spark-datasource and spark-common-test into integration/spark
   
    897 files changed, 3992 insertions(+), 4619 deletions(-)
   
   commit 9b2d0be85433ecf8d17c5f8e42ffcd9692719440
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:31:18 2020 +0800
   
       update docs
   
    14 files changed, 29 insertions(+), 29 deletions(-)
   
   commit 667ffdc27f3f86b398aa79d22ebae2423b530f45
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:29:22 2020 +0800
   
       move datamap to index
   
    27 files changed, 5 insertions(+), 5 deletions(-)
   
   commit 8760f4d05b4781f4af4e923984f729358c67f0f1
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:28:03 2020 +0800
   
       move datamap/mv to mv
   
    83 files changed, 39 insertions(+), 27 deletions(-)
   
   commit 42fc8cb13554cf190716d1471b8e7c9cf28babb5
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:27:00 2020 +0800
   
       move secondary_index to index/secondary-index
   
    25 files changed, 26 insertions(+), 26 deletions(-)
   
   commit 4be80ba505bb29b93743b5995ddb2b3eb9c7679d
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:25:56 2020 +0800
   
       move examples/spark2 to examples/spark
   
    50 files changed, 44 insertions(+), 44 deletions(-)
   
   commit 723fb2f74f41bc05caa299b9caecd28cc96eb8cd
   Author: QiangCai <[hidden email]>
   Date:   Mon Feb 24 17:19:38 2020 +0800
   
       move carbondata/store to carbondata/sdk
   
    76 files changed, 3 insertions(+), 3 deletions(-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590264594
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/430/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590291035
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2130/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592#issuecomment-590397435
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3592: [Re-factory] Re-factory modules
URL: https://github.com/apache/carbondata/pull/3592
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services