[GitHub] [carbondata] QiangCai opened a new pull request #3891: [CARBONDATA-3889] Enable scala style check

[GitBox]

QiangCai opened a new pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891


    ### Why is this PR needed?
   1. scala style checking is not working during compile and IntelliJ IDEA does not use the scala style config in the dev folder.
   2. Intellij IDEA will sort import with different order
   
    ### What changes were proposed in this PR?
    1. move scalastyle-config.xml to the parent project folder.
       a) IntelliJ IDEA will show the style error during coding.
       b) Fix scala style issue which the scala style checking report during maven compile.
    2. change java-code-format-template.xml to sort import as Scalastyle.
   
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#issuecomment-674026429


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3720/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#issuecomment-674033840


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1981/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

xubo245 commented on a change in pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#discussion_r474373904



##########
File path: pom.xml
##########
@@ -431,9 +431,10 @@
           <failOnWarning>false</failOnWarning>
           <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
           <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
-          <configLocation>${dev.path}/scalastyle-config.xml</configLocation>
+          <configLocation>scalastyle-config.xml</configLocation>

Review comment:
       why. do you remove ${dev.path}/?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

QiangCai commented on a change in pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#discussion_r474375939



##########
File path: pom.xml
##########
@@ -431,9 +431,10 @@
           <failOnWarning>false</failOnWarning>
           <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
           <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
-          <configLocation>${dev.path}/scalastyle-config.xml</configLocation>
+          <configLocation>scalastyle-config.xml</configLocation>

Review comment:
       moved scalastyle-config.xml into the parent project folder.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

xubo245 commented on pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#issuecomment-678023209






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

xubo245 commented on pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#issuecomment-678023289


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

xubo245 removed a comment on pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#issuecomment-678023289






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit closed pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

xubo245 commented on pull request #3891:
URL: https://github.com/apache/carbondata/pull/3891#issuecomment-679459877






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]