[GitHub] [carbondata] VenuReddy2103 opened a new pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] VenuReddy2103 opened a new pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox

VenuReddy2103 opened a new pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750


   
   
    ### Why is this PR needed?
    Current code base has many types of indexes. To avoid the confusion and be more specific, have changed the index_handler property to spatial_index. Also changed the isIndexColumn/setIndexColumn to isSpatialColumn/setSpatialColumn respectively.
   
    ### What changes were proposed in this PR?
   Have changed the index_handler property to spatial_index. Also changed the isIndexColumn/setIndexColumn to isSpatialColumn/setSpatialColumn respectively.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-624890569


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2964/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-624898001


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1246/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-625061586


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2967/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629393992


   @VenuReddy2103 Please rebase


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629520321


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1323/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629521669


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3042/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

VenuReddy2103 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629593457


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629607179


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3044/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629607252


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1325/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

jackylk commented on pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750#issuecomment-629692291


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3750: [CARBONDATA-3548]Renamed index_handler to spatial_index property and indexColumn is changed to spatialColumn

GitBox
In reply to this post by GitBox

asfgit closed pull request #3750:
URL: https://github.com/apache/carbondata/pull/3750


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]