[GitHub] [carbondata] VenuReddy2103 opened a new pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] VenuReddy2103 opened a new pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox

VenuReddy2103 opened a new pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760


    ### Why is this PR needed?
   Insert into table select from another table throws exception for spatial tables. NoSuchElementException exception is thrown with 'mygeohash' column.
   
    ### What changes were proposed in this PR?
   
   - Excluded spatial columns during getReArrangedIndexAndSelectedSchema. And have set the carbonLoadModel.setIndexColumnsPresent if spatial columns are present during rearranging.
   - If the target spatial table has sort_scope configured as global-sort, have made the insert flow to go through `loadDataFrame()` instead of `insertDataUsingGlobalSortWithInternalRow()` in CarbonDataRDDFactory.loadCarbonData(). This ensures that it goes through existing load without Conversion Step and spatial column values are regenerated in the flow.
   - Added testcases for
   1. insert into table without sort_scope configuration.
   2. insert into table with sort_scope configuration.
   3. Load data to table with partition.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox

CarbonDataQA1 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-626646505


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2995/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-626648886


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1277/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-629307229


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 removed a comment on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

kunal642 removed a comment on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-629307229


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-629307490


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-629391893


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3038/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-629392185


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1319/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760#issuecomment-629392704


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3760: [CARBONDATA-3815]Insert into table select from another table throws exception for spatial tables

GitBox
In reply to this post by GitBox

asfgit closed pull request #3760:
URL: https://github.com/apache/carbondata/pull/3760


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]