[GitHub] [carbondata] Zhangshunyu opened a new pull request #4029: refact carbon util

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Zhangshunyu opened a new pull request #4029: refact carbon util

GitBox

Zhangshunyu opened a new pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029


    ### Why is this PR needed?
    Currentlly, we have some Carbon{$FUNCTION_NAME}Util and some CarbonUtil/CarbonUtils, it has some mixed functions in  CarbonUtil , we should clean code.
   
    ### What changes were proposed in this PR?
   Refact the code to clean it
   
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: refact carbon util

GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-734645757


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4939/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: refact carbon util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-734647130


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3185/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on pull request #4029: refact carbon util

GitBox
In reply to this post by GitBox

QiangCai commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739614278


   please rebase and perfect the title


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739620454


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3331/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739620953


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5088/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739634371


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3307/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739648475


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5064/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Zhangshunyu commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

Zhangshunyu commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-740289158


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-740328745


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5105/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-740330449


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3344/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Zhangshunyu commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

Zhangshunyu commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-740470064


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-740524864


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5112/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-740530153


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3350/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

QiangCai commented on pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029#issuecomment-742909031


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4029: [HOTFIX] Refact Carbon Util

GitBox
In reply to this post by GitBox

asfgit closed pull request #4029:
URL: https://github.com/apache/carbondata/pull/4029


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]