[GitHub] [carbondata] ajantha-bhat opened a new pull request #3563: [HOTFIX] Fix testcase failure after #3528

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3563: [HOTFIX] Fix testcase failure after #3528

GitBox
ajantha-bhat opened a new pull request #3563: [HOTFIX] Fix testcase failure after #3528
URL: https://github.com/apache/carbondata/pull/3563
 
 
    ### Why is this PR needed?
    PR#3528 was an old build, test was not ran on the latest master. Hence one test case failed.
   
    ### What changes were proposed in this PR?
   updated the test case, as now update by value flow is introduced in 3528 for subquires. Exception callstack will be different.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on issue #3563: [HOTFIX] Fix testcase failure after #3528

GitBox
ajantha-bhat commented on issue #3563: [HOTFIX] Fix testcase failure after #3528
URL: https://github.com/apache/carbondata/pull/3563#issuecomment-570887815
 
 
   @jackylk : please check this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jackylk commented on issue #3563: [HOTFIX] Fix testcase failure after #3528

GitBox
In reply to this post by GitBox
jackylk commented on issue #3563: [HOTFIX] Fix testcase failure after #3528
URL: https://github.com/apache/carbondata/pull/3563#issuecomment-570890870
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3563: [HOTFIX] Fix testcase failure after #3528

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3563: [HOTFIX] Fix testcase failure after #3528
URL: https://github.com/apache/carbondata/pull/3563#issuecomment-570892462
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1474/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3563: [HOTFIX] Fix testcase failure after #3528

GitBox
In reply to this post by GitBox
asfgit closed pull request #3563: [HOTFIX] Fix testcase failure after #3528
URL: https://github.com/apache/carbondata/pull/3563
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services