[GitHub] [carbondata] ajantha-bhat opened a new pull request #3937: [CARBONDATA-3995] Support presto querying older complex type stores

[GitBox]

ajantha-bhat opened a new pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937


    ### Why is this PR needed?
    Before carbon 2.0, complex child length is stored as SHORT for string, varchar, binary, date, decimal types.
   So, In 2.0 as it is stored as INT, presto complex query code always assumes it as  INT
   and goes to out of bound exception when old store is queried.
   
    ### What changes were proposed in this PR?
   If INT_LENGTH_COMPLEX_CHILD_BYTE_ARRAY encoding is present, parse as INT, else parse as SHORT.
   so, that both stores can be queried.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No [upgrade scenario]
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694711366


   @kumarvishal09 , @kunal642 , @akashrn5 : please check and merge


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694757377


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2381/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694763475


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4122/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694767622


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694818288


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4125/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694825616


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2384/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694856042


   verified in the cluster also. Tested ok.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694878769


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

kunal642 commented on pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937#issuecomment-694935778


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit closed pull request #3937:
URL: https://github.com/apache/carbondata/pull/3937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]