[GitHub] [carbondata] ajantha-bhat opened a new pull request #4006: [HOTFIX] Avoid calling SecondaryIndexUtil.readFileFooter() for every splits identified during SI creation

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat opened a new pull request #4006: [HOTFIX] Avoid calling SecondaryIndexUtil.readFileFooter() for every splits identified during SI creation

GitBox

ajantha-bhat opened a new pull request #4006:
URL: https://github.com/apache/carbondata/pull/4006


    ### Why is this PR needed?
   1. Redundant functionality SecondaryIndexUtil.readFileFooter() exist for SI creation  
   2. Some info logs can be changed to debug to avoid looping.
   
    ### What changes were proposed in this PR?
   1. remove SecondaryIndexUtil.readFileFooter() for SI creation  
   2. Some info logs to debug to avoid looping.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #4006: [HOTFIX] Avoid calling SecondaryIndexUtil.readFileFooter() for every splits identified during SI creation

GitBox

CarbonDataQA1 commented on pull request #4006:
URL: https://github.com/apache/carbondata/pull/4006#issuecomment-723014595


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4782/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #4006: [HOTFIX] Avoid calling SecondaryIndexUtil.readFileFooter() for every splits identified during SI creation

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #4006:
URL: https://github.com/apache/carbondata/pull/4006#issuecomment-723015155


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3024/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] QiangCai commented on pull request #4006: [HOTFIX] Avoid calling SecondaryIndexUtil.readFileFooter() for every splits identified during SI creation

GitBox
In reply to this post by GitBox

QiangCai commented on pull request #4006:
URL: https://github.com/apache/carbondata/pull/4006#issuecomment-723844594


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4006: [HOTFIX] Avoid calling SecondaryIndexUtil.readFileFooter() for every splits identified during SI creation

GitBox
In reply to this post by GitBox

asfgit closed pull request #4006:
URL: https://github.com/apache/carbondata/pull/4006


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]