[GitHub] [carbondata] jack86596 opened a new pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 opened a new pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox

jack86596 opened a new pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065


    ### Why is this PR needed?
    Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS.
   
    ### What changes were proposed in this PR?
   If the location doesn't have schema, add the fs.defaultFS schema to the beginning of the location.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox

CarbonDataQA2 commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749583533


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3471/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749584636


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5232/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749652691


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5234/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749652973


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3473/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

ajantha-bhat commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749944567


   @jack86596 , please change description to scheme (schema --> scheme)
   
   and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata right ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

ajantha-bhat edited a comment on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749944567


   @jack86596 , please change description abd heading to **scheme** (schema --> **scheme**)
   
   and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata right ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

ajantha-bhat edited a comment on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749944567


   @jack86596 , please change description abd heading to **scheme** (schema --> **scheme**)
   
   and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata and db folder right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

ajantha-bhat edited a comment on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749944567


   @jack86596 , please change description and heading to **scheme** (schema --> **scheme**)
   
   and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata and db folder right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have schema, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

ajantha-bhat edited a comment on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749944567


   @jack86596 , please change description and heading to **scheme** (schema --> **scheme**)
   
   a) and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata and db folder right?
   b) what is the behavior of parquet table for the same ? it takes default fs or local ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have scheme, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

jack86596 commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749960335


   > @jack86596 , please change description and heading to **scheme** (schema --> **scheme**)
   Done.
   >
   > a) and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata and db folder right?
   SQL: create table table_with_location(a int,b string) stored as carbondata location '/tmp/table_with_location';
   > b) what is the behavior of parquet table for the same ? it takes default fs or local ?
   Parquet will take default fs.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 removed a comment on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have scheme, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

jack86596 removed a comment on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749960335


   > @jack86596 , please change description and heading to **scheme** (schema --> **scheme**)
   Done.
   >
   > a) and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata and db folder right?
   SQL: create table table_with_location(a int,b string) stored as carbondata location '/tmp/table_with_location';
   > b) what is the behavior of parquet table for the same ? it takes default fs or local ?
   Parquet will take default fs.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have scheme, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

jack86596 commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749960785


   > @jack86596 , please change description and heading to **scheme** (schema --> **scheme**)
   >
   > a) and can you share here the create table with location syntax you are using ? it will create non transactional table without metadata and db folder right?
   > b) what is the behavior of parquet table for the same ? it takes default fs or local ?
   
   Title changed.
   a) SQL: create table table_with_location(a int,b string) stored as carbondata location '/tmp/table_with_location';
   b) Parquet will use default fs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have scheme, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

ajantha-bhat commented on pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065#issuecomment-749962019


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4065: [CARBONDATA-4089] Create table with location, if the location doesn't have scheme, the default will be local file system, which is not the file system defined by fs.defaultFS

GitBox
In reply to this post by GitBox

asfgit closed pull request #4065:
URL: https://github.com/apache/carbondata/pull/4065


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]