[GitHub] [carbondata] jack86596 opened a new pull request #4149: [CARBONDATA-4206] Support rename SI table

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 opened a new pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox

jack86596 opened a new pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149


    ### Why is this PR needed?
   Currently rename SI table can succeed, but after rename, insert and query on main table failed, throw no such table exception. This is because after SI table renamed, main table's tblproperties didn't get update, it still stores the old SI table name, when refering to SI table, it tries to find the SI table by old name, which leads to no such table exception.
   
    ### What changes were proposed in this PR?
   After SI table renamed, update the main table's tblproperties with new SI information.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-858654696


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5536/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-858657447


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3793/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

jack86596 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-858756928


   retest this please


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-858871795


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5537/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-858873734


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3794/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

jack86596 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-859175007






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-859224317






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] jack86596 edited a comment on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

jack86596 edited a comment on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-859404886


   @kunal642 @Indhumathi27 pls help review, above build failure is one presto test case, running again now. Thanks.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-860600775


   LGTM


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] kunal642 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

kunal642 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-860829383


   LGTM


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-861165265


   retest this please


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-861239202


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3801/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-861247784


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5544/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

Indhumathi27 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-862041824


   retest this please


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-862121741


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5555/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

CarbonDataQA2 commented on pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149#issuecomment-862128620


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3812/
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #4149: [CARBONDATA-4206] Support rename SI table

GitBox
In reply to this post by GitBox

asfgit closed pull request #4149:
URL: https://github.com/apache/carbondata/pull/4149


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]