[GitHub] [carbondata] kunal642 opened a new pull request #3680: [WIP] Fixed desc formatted and show segment data size issues

[GitBox]

kunal642 opened a new pull request #3680: [WIP] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680
 
 
    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3680: [WIP] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-604400494
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/855/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3680: [WIP] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-604409056
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2562/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on issue #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-609678363
 
 
   @akashrn5 @jackylk @ajantha-bhat Please review
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on a change in pull request #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#discussion_r403966201
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
 ##########
 @@ -527,10 +527,11 @@ public static boolean updateTableStatusFile(CarbonTable carbonTable, String segm
         for (LoadMetadataDetails detail : listOfLoadFolderDetailsArray) {
           // if the segments is in the list of marked for delete then update the status.
           if (segmentId.equals(detail.getLoadName())) {
+            detail.setLoadEndTime(System.currentTimeMillis());
 
 Review comment:
   why we need this change? is it sepicific to non carbon segment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on issue #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-609694102
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-609764288
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/941/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-609766065
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2651/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on a change in pull request #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#discussion_r404568644
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
 ##########
 @@ -527,10 +527,11 @@ public static boolean updateTableStatusFile(CarbonTable carbonTable, String segm
         for (LoadMetadataDetails detail : listOfLoadFolderDetailsArray) {
           // if the segments is in the list of marked for delete then update the status.
           if (segmentId.equals(detail.getLoadName())) {
+            detail.setLoadEndTime(System.currentTimeMillis());
 
 Review comment:
   yes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on a change in pull request #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#discussion_r404568644
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
 ##########
 @@ -527,10 +527,11 @@ public static boolean updateTableStatusFile(CarbonTable carbonTable, String segm
         for (LoadMetadataDetails detail : listOfLoadFolderDetailsArray) {
           // if the segments is in the list of marked for delete then update the status.
           if (segmentId.equals(detail.getLoadName())) {
+            detail.setLoadEndTime(System.currentTimeMillis());
 
 Review comment:
   yes, just adding the loadend time for non carbon segments as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on a change in pull request #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#discussion_r404582168
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
 ##########
 @@ -527,10 +527,11 @@ public static boolean updateTableStatusFile(CarbonTable carbonTable, String segm
         for (LoadMetadataDetails detail : listOfLoadFolderDetailsArray) {
           // if the segments is in the list of marked for delete then update the status.
           if (segmentId.equals(detail.getLoadName())) {
+            detail.setLoadEndTime(System.currentTimeMillis());
 
 Review comment:
   is this common code to both carbon and non carbon segments? if it is  then better to set it only in non carbon segments case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on a change in pull request #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#discussion_r404617995
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
 ##########
 @@ -527,10 +527,11 @@ public static boolean updateTableStatusFile(CarbonTable carbonTable, String segm
         for (LoadMetadataDetails detail : listOfLoadFolderDetailsArray) {
           // if the segments is in the list of marked for delete then update the status.
           if (segmentId.equals(detail.getLoadName())) {
+            detail.setLoadEndTime(System.currentTimeMillis());
 
 Review comment:
   I think we should not add external segments check for common things, it should be okay if we set here because we are not using this end time in any other logic/decision making

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on issue #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680#issuecomment-610244816
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3680: [CARBONDATA-3766] Fixed desc formatted and show segment data size issues
URL: https://github.com/apache/carbondata/pull/3680
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services