[GitHub] [carbondata] kunal642 opened a new pull request #3700: [CARBONDATA-3767] Added spark binary version to related modules

[GitBox]

kunal642 opened a new pull request #3700: [CARBONDATA-3767] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700
 
 
    ### Why is this PR needed?
    For deploying multiple carbon jars version with different spark versions, the jar/module names should be different
   
    ### What changes were proposed in this PR?
   Add spark binary version to the related modules to distinguish the jars based on spark version
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on issue #3700: [CARBONDATA-3767] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700#issuecomment-610870623
 
 
   @jackylk @ravipesala Please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3700: [CARBONDATA-3767] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700#issuecomment-610921191
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/973/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3700: [CARBONDATA-3767] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700#issuecomment-610948097
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2685/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3700: [WIP] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700#discussion_r410568692
 
 

 ##########
 File path: integration/spark/pom.xml
 ##########
 @@ -40,7 +40,7 @@
     <build.directory.projectFormat>../../format/target</build.directory.projectFormat>
     <build.directory.projectSpark>../../integration/spark/target</build.directory.projectSpark>
     <!--<build.directory.projectHive>../../integration/hive/target</build.directory.projectHive>-->
-    <!--<build.directory.projectPresto>../../integration/presto/target</build.directory.projectPresto>-->
+    <!--< build.directory.projectPresto>../../integration/presto/target</build.directory.projectPresto>-->
 
 Review comment:
   can you delete all commented line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3700: [WIP] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700#discussion_r410569180
 
 

 ##########
 File path: mv/plan/pom.xml
 ##########
 @@ -26,7 +26,7 @@
     <relativePath>../../pom.xml</relativePath>
   </parent>
 
-  <artifactId>carbondata-mv-plan</artifactId>
+  <artifactId>carbondata-mv-plan_${spark.binary.version}</artifactId>
 
 Review comment:
   It is to name it `carbondata-mv-plan-spark_${spark.binary.version}` to indicate the version number is for spark

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3700: [WIP] Added spark binary version to related modules
URL: https://github.com/apache/carbondata/pull/3700#discussion_r410569382
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -124,6 +124,7 @@
     <!--    default properties-->
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <snappy.version>1.1.2.6</snappy.version>
+    <spark.binary.version>2.3</spark.binary.version>
 
 Review comment:
   default version is not 2.4?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services