[GitHub] [carbondata] marchpure opened a new pull request #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] marchpure opened a new pull request #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
marchpure opened a new pull request #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544
 
 
   Modification reason:
   (1) StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map.
   (2) ArrayIndexOutOfBuoundsException When Inserting Select From a Parquet Table with a map with empty key and empty value
   (3) Result is incorrect when Inserting Select From a Parquet Table with a Struct with Empty String, The result will be null while the correct result is "".
   
   Modification content:
   (1) When the input value is ARRAY(), return EMPTY_DATA_RETURN in the FieldConverter.scala, ArrayParserImpl handle it.
   (2) When the input value is ARRAY(""), return EMPTY STRING ->"" in the FieldConverter.scala, ArrayParserImpl handle it.
   (3) When the input value is MAP("",""), return EMPTY STRING ->"" in the FieldConverter.scala, MapParserImpl handle it.
   (4) When the input value is MAP(), return EMPTY_DATA_RETURN ->"" in the FieldConverter.scala, MapParserImpl handle it.
   (5) When the input value is Struct(""), the StructParserImpl handle the EMPTY STRING
   
   
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
   
    - [ ] Any backward compatibility impacted?
   
    - [ ] Document update required?
   
    - [ ] Testing done
           Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
         
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544#issuecomment-569555779
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1334/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544#issuecomment-569556462
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1344/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544#issuecomment-569556872
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1357/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544#issuecomment-569560317
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1335/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] marchpure closed pull request #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
In reply to this post by GitBox
marchpure closed pull request #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544#issuecomment-569569278
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1346/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3544: [Carbondata-3631] StringIndexOutOfBoundsException When Inserting Select From a Parquet Table with Empty array/map
URL: https://github.com/apache/carbondata/pull/3544#issuecomment-569569448
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1359/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services