[GitHub] [carbondata] marchpure opened a new pull request #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…

[GitBox]

marchpure opened a new pull request #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…
URL: https://github.com/apache/carbondata/pull/3552
 
 
   … Properties
   
    ### Why is this PR needed?
    Modification reason: In the insert carbontable select from a parquet table processing, if the binary column has the content '\001', like 'col1\001col2', the content before '\001' will be truncated as '\001' is the Complex Delimiter. The problem is that Complex Delimiter can't be configured in the insert flow, which needs to improve.
   
    ### What changes were proposed in this PR?
   Modification content: We add the configuration of complex delimiters in the CarbonProperties, which will be loaded in the LoadOption.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…
URL: https://github.com/apache/carbondata/pull/3552#issuecomment-569904813
 
 
   Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1376/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…
URL: https://github.com/apache/carbondata/pull/3552#issuecomment-569912037
 
 
   Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1386/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…
URL: https://github.com/apache/carbondata/pull/3552#issuecomment-569913742
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1397/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…
URL: https://github.com/apache/carbondata/pull/3552#issuecomment-570424889
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3552: [CARBONDATA-3644] Support Configuration of Complex Delimiters in Carbon…
URL: https://github.com/apache/carbondata/pull/3552
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services